fix: tryin to fix audio array buffer #725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejmakowski2003
requested review from
mdydek,
michalsek,
miloszwielgus,
poneciak57 and
vltkv
poneciak57
approved these changes
Oct 8, 2025
michalsek
reviewed
Oct 9, 2025
packages/react-native-audio-api/common/cpp/audioapi/core/effects/WorkletNode.cpp
Show resolved
Hide resolved
mdydek
requested changes
Oct 10, 2025
packages/react-native-audio-api/common/cpp/audioapi/core/sources/AudioBuffer.h
Outdated
Show resolved
Hide resolved
poneciak57
approved these changes
Oct 10, 2025
michalsek
approved these changes
Oct 13, 2025
mdydek
approved these changes
Oct 13, 2025
added 2 commits
October 13, 2025 11:25
michalsek
approved these changes
Oct 13, 2025
maciejmakowski2003
added a commit
that referenced
this pull request
Oct 13, 2025
* fix: tryin to fix audio array buffer * fix: fixed wrong ctor order * fix: removed forward declaration * fix: removed pragma once from source file??? * fix: revert set external memory pressure * ci: lint * refactor: set external memory pressure on each element instead of whole array * ci: lint --------- Co-authored-by: maciejmakowski2003 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RNAA-269
Closes RNAA-276
Introduced changes
Checklist